On Mon, Jun 1, 2009 at 8:37 AM, Travis Collier <[email protected]> wrote: > Answering my own email... bad form I suppose but I got it working > pretty easily... > > parcellfun needs to call waitpid to clear those child processes. Simple fix. > > There was a minor bug with the options parsing... it failed when no > options were set. Fixed with a simple protecting if. > > I also included a 'VerboseLevel' option which allows for quiet (0), > normal (1), or more (2+) levels of verbosity to the output. > I'd humbly encourage including this in any reasonably complex > function... especially ones where debugging output is frequently > desirable. > > Here is a diff against the version of parcellfun.m contained in > general-1.1.2 (the current one on octave-forge)... please drop me a > note if I should instead post the full file. >
Hi again, I'm glad to see someone else contributing to parcellfun (or the "general" package). The suggested improvement as well as bug fix are OK, but I have a couple of suggestions/advices: 1. Never send context-free patches (such as the one you posted) - they are too risky to apply. Use the -c or -u switch to diff (or see 2. below). For more info, see `man diff'. 2. If possible, use the SVN sources to work with. Under unixy OSes, this should be as easy as doing svn co https://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/main/general in a suitable directory (this will check out just the general package, strip the path if you want the whole tree). After you edit some files in the working copy, you can just use `svn diff' to make a proper diff and send that over the mail, preferably as an attachment with MIME type text/x-patch, text/x-diff or text/plain (I think Gmail will do this automatically if you use the .diff or .patch extension). "svn diff" will always generate a proper patch, so you can ignore advice 1. if you do so. Pretty convenient SVN clients also exist for Windows and Mac. 3. Don't mix logically independent changes. Yes, "logically independent" is vague - you should use your common sense, but some basic rules of thumb exist. For instance, you shouldn't mix an extension with a bug fix (which apparently you just attempted to), even if the bug fix is trivial. Make it two separate patches. 4. If you find yourself making more contributions, consider getting a SourceForge account and join the OctaveForge project. Please re-post your patch taking these under consideration (and of course ask if you have doubts). best regards -- RNDr. Jaroslav Hajek computing expert & GNU Octave developer Aeronautical Research and Test Institute (VZLU) Prague, Czech Republic url: www.highegg.matfyz.cz ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com _______________________________________________ Octave-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/octave-dev
