Thanks Søren. I have subscribed to the octave-dev list. I will make
the changes you suggested and post an updated version.
Cheers,
-Pete
Søren Hauberg wrote:
> Hi
>
> man, 28 09 2009 kl. 08:23 -0400, skrev Pete Gonzalez:
>> We are offering to contribute an original implementation of the filter
>> design algorithm described in this paper:
>>
>> I. W. Selesnick, M. Lang, and C. S. Burrus. A modified algorithm for
>> constrained least square design of multiband FIR filters without
>> specified transition bands. IEEE Trans. on Signal Processing,
>> 46(2):497-501, February 1998.
>
> Cool! I'm not really a signal processing guy (I do some image
> processing, though), so I can't really comment on the actual algorithm.
> That being said, I do think it sounds like a valuable contribution to
> the 'signal' package.
>
> Since the function should be part of a package, I think it should be
> discussed at the Octave-Forge mailing list. So, I've moved the
> discussion there.
>
> As to the actual code, then I only have few comments/questions:
>
> *) Why do you need the 'MallocArray' class? Can't you just use
> the 'Matrix' or 'ColumnVector' class?
>
> *) You need to do some error checking in the input handling.
> Basically, you need to some
>
> if (error_state)
> {
> error ("something");
> return octave_value ();
> }
>
> after each call to '*_value ()' with '*' being e.g. 'double'.
>
> Otherwise I guess things look good :-)
>
> Søren
>
>
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Octave-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/octave-dev
