2011/10/11 Rudy Eschauzier <reschauz...@yahoo.com>: > Hi Carnë, > Yes, I am very sure. In fact, removing zero and near-zero elements > introduces a bug. Note how both a_out and b_out are polynomials. Taking an > element out, will shift the polynomial weights to the next power, messing up > the entire polynomial. The results will be both bizarre and difficult to > track down, because of their random nature. > I included a number of test cases for both impinvar and invimpinvar. The > tests are based on calculating the impulse response of the continuous-time > system and the equivalent discrete-time system. They include some extreme > cases, with poles of multiple order, multiple complex poles and complex > residues. As the name suggests, the impulse invariance transform should give > exactly the same results for both systems at the sample times n*ts. With the > proposed changes, the two routines pass all 24 tests. Sure enough, when > changing the two lines to remove small values, impinvar will fail. > Also, for each of the 12 impinvar cases, the results exactly matches the > Matlab result (Matlab does not have the inverse impulse invariance > transform). > Hope this helps, let me know if you need any additional information. > Thanks, > Rudy.
Ok. I had just followed the examples on this page http://www.uccs.edu/~cfelton/ece5655/chp8_matlab.html to remove those entries. I'll commit those changes now. Thank you a lot for your time improving this. The whole community wins. Carnë ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
