tir, 29 11 2011 kl. 04:09 +0000, skrev Carnë Draug: > Hi > > I was looking through isbw which is supposed to return 1 or 0 wether a > matrix is a black and white image. > > The way it's working now, it returns 1 if all values in a matrix are 0 > or 1. This is not completely correct since a grayscale image can be of > values 0 and 1. In my view, it should check if it's a logical array. > This was also matlab's behaviour (they removed this function with > 2011b). > > I would like to make this change but I'm afraid it will break people > code. Does anyone oposes to this change? I could make it behave as it > is now but issuing an warning if a non logical matrix of 0 and 1 > array is being used and later actually fix it. Anyone has an opinion?
I don't have strong opinions as I doubt many people are using this function. I think your suggestion is fine, so I would go ahead with that. You could consider accepting an optional second input argument that allows the user to switch between the current behaviour and the new behaviour if you want. Søren ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev