On 3 December 2011 21:43, Ferran Mesas <ferran.me...@gmail.com> wrote: > Hello everyone, > > I rewrote huffmandeco() from the communications package. The one in > communications 1.1.0 uses a brute-force O(n^3) or O(n^4) solution. > I implemented it using a binary tree and now takes O(n) operations > (please note that I am not used to big O notation and numbers may be > off). > I attached the function and another one used to convert the dictionary > to a tree to this mail. > > > There's another related function, huffmandict(), that initializes two > cell arrays like this: > > list{1:L} = [ ]; > > Octave complains when this is found in 3.2.4 and 3.4.3. I don't know > if it is possible to initialize cell arrays like that or if it used to > be, as the function dates to 2006. > I used list = cell(1,L); instead and now works without problem. > > My sourceforge username is vodkano. > > This is my first contribution to libre software and i feel great! > > Ferran
Hi Ferran sorry for the very late reply. I was waiting that someone more knowledgeable on the subject said anything. Since no one has after 3 days, I can make the commit. Some questions though * dict2tree says that it is meant to be used by huffmandict on the "documentation" but it is actually used by huffmandeco. Do you plan to make it used by huffmandict as well? If so, should the function be made private? If not, should it be a subfunction of huffmandeco? * can I change the license to GPLv3+? * when checking the input, instead of error("error mesage about bad input") it's recommended to use print_usage() instead I can make all this changes myself, no problem. Carnë ------------------------------------------------------------------------------ Cloud Services Checklist: Pricing and Packaging Optimization This white paper is intended to serve as a reference, checklist and point of discussion for anyone considering optimizing the pricing and packaging model of a cloud services business. Read Now! http://www.accelacomm.com/jaw/sfnl/114/51491232/ _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev