[ http://issues.apache.org/jira/browse/OFBIZ-68?page=comments#action_12418571 ]
Jacopo Cappellato commented on OFBIZ-68: ---------------------------------------- Chris, your work is very good and I've committed it, with some changes, in rev. 7906. Please, review it and see if everything is ok: I cleaned up a bit of the original code (following your suggestions in the comments in the screen) and I've also fixed two small errors inyour patch (in the ordermgr/RequestScreens.xml in chunk at line 107). Before working at the entry and order screens (rather messed up and frequently modified) you could refactor the quote screen as well. Also, consider that tomorrow David will move the OFBiz codebase to the ASF server: if you'll start working on this on monday, maybe it's better. Again thanks > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: ViewRequest.patch > > There are currently 7 freemarker files in the order applications that have > multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good > chunk of reusable code. When multiple screenlets inhabit the same template > file, you either have to reuse all of the code or none if it. By splitting > these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in > addition to ecomerce and wholesale and salesrep, making it reusable will > lower the maintenance those applications require. Please vote on this and I > will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
