[ http://issues.apache.org/jira/browse/OFBIZ-68?page=all ]
Chris Howe updated OFBIZ-68:
----------------------------
Attachment: showPromotionDetails.patch
showPromotionDetails.patch
splits up order/webapp/ordermgr/entry/cart/showPromotionDetails.ftl and all
screen definitions that call it
I'm not going to split up /entry/cart/showcart.ftl because it contains
javascript functions at the begining that are not used in showcart.ftl. The
functions are used in subsequent template files that are called after
showcart.ftl. A consensus needs to be reached on how to best handle this as it
is already kind of a mess.
> Break up application templates with multiple screenlets
> -------------------------------------------------------
>
> Key: OFBIZ-68
> URL: http://issues.apache.org/jira/browse/OFBIZ-68
> Project: The Open For Business Project
> Type: Improvement
> Components: order
> Reporter: Chris Howe
> Assignee: Jacopo Cappellato
> Attachments: OrderEntryOrderHeader.patch, OrderOrderHeader.patch,
> ViewQuote.patch, ViewRequest.patch, cssChange.patch,
> showPromotionDetails.patch
>
> There are currently 7 freemarker files in the order applications that have
> multiple screenlets in the same template file. They are:
> entry/cart/showcart.ftl
> entry/cart/showPromotionDetails.ftl
> entry/order/orderheader.ftl
> entry/poheader.ftl (may not be used)
> order/orderheader.ftl
> quote/ViewQuoteInfo.ftl
> request/ViewRequestInfo.ftl
> I would like these to be split up. Screenlets, when defined make up a good
> chunk of reusable code. When multiple screenlets inhabit the same template
> file, you either have to reuse all of the code or none if it. By splitting
> these up, the parts are more likely to be reused than the whole.
> Because the order application is the base for so many custom applications in
> addition to ecomerce and wholesale and salesrep, making it reusable will
> lower the maintenance those applications require. Please vote on this and I
> will submit patches. Thanks
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
