[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12424178 ] Jacques Le Roux commented on OFBIZ-56: --------------------------------------
Hi Bj, I did not take the time to review you patch (it's time to sleep here ;o). My comments here are only formals. I think it would be better (ie easier for commiters) to attach your patch as file (see option above on left). Another point : please dont use absolute path in your path (for eg C:/projects/java/ofbiz_incubator_trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java ). You should use something like applications/content/src/org/ofbiz/content/email/EmailServices.java). One more time less work for commiters. You may find these interesting (hope you will find some time to read them ;o) http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions (notably this link inside this document : http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html) Thanks > incoming email attachments buggy > -------------------------------- > > Key: OFBIZ-56 > URL: http://issues.apache.org/jira/browse/OFBIZ-56 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: content > Affects Versions: SVN trunk > Reporter: Si Chen > Fix For: SVN trunk > > > storeIncomingEmail has problems with attachments. If you send two images, > the same image ends up being stored twice. Some types of content are not > stored correctly (such as word docs with images embedded). Other times the > /ViewSimpleContent request has problems retrieving content correctly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
