[ http://issues.apache.org/jira/browse/OFBIZ-157?page=comments#action_12429820 ] Jacques Le Roux commented on OFBIZ-157: ---------------------------------------
Rodriguo, I reviewed your patch, some comments : You put your name and email just under the ASL2 header. I'm not sure it's a good practise (a PMC member may be helpful here). When I recently updated french properties files we agreed with Neogia people (Peter exactly ;o) to suppress such things (both theirs and mine were in). Do you really want to keep them ? You used some RBE options that I have experienced are no good except if you were sure that this options will always be used (which is not sure as not everybody is using *and will be using RBE in the future*...) . align equal signs : because if you add a new label longuer than existing ones you will get a lot of false modifications . blank around equal signs : same problem than above Apart these notes, it seems OK to me (but I don't know Spanish ;o) I prefer to wait a PMC member advice here... Sorry for the waiting > Accounting Component Translation (Spanish) > ------------------------------------------ > > Key: OFBIZ-157 > URL: http://issues.apache.org/jira/browse/OFBIZ-157 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: accounting > Reporter: Victor Hugo Hernandez Posadas > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: AccountingUiLabels_es.properties, translation_es.patch, > translations.zip > > > I'm doing the translation of the Accounting component, I've not yet finished > but here's an advance in the attached file, I'll thank if someone can to > include it to the OFBiz SVN Tree, any observations will be valuated. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
