[ 
https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462691
 ] 

Jacopo Cappellato commented on OFBIZ-588:
-----------------------------------------

Ashish,

yes Chris is right (and sorry for not being very clear about this task); 
however I'm reviewing the patch for the accounting component and it looks you 
did the right thing, except for the <div> elements inside table cells <td> that 
should be removed and not replaced by <p> tags.
So for example:

<td><div class="tabletext">some text...</div></td>
should become
<td>some text...</td>

and 
<td><div class="tabletext"><b>ID</b></div></td>
should probably become
<th>ID</th>
(to all: is it correct?)

Thanks for your great help!



> Replace all div class="tabletext" wrappers with <p> or just remove them and 
> set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-588
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-588
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: accounting, content, ecommerce, framework, hhfacility, 
> humanres, manufacturing, marketing, order, party, product, workeffort
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: Accounting_Jan06.patch, Product_Jan06_Phase1.patch, 
> WorkEffort_Jan06.patch
>
>
> all <div class="tabletext"> wrappers can be removed, the exception being 
> where they are used like <p>s - the default text style can be set on body;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to