Re: CSS Layout and Other Cleanups in the Manager Applications

[Andrew Zeneski]

I'm not too sure about combining all styles into one css file. Cleaning them up surely would be a good thing, but tabstyles.css was designed to handle the tab sections of screens. Only needed to be included in screens which use the top level tabs.

Just my two cents.

Andrew

On Jan 3, 2007, at 7:22 PM, Adrian Crum wrote:

Keeping this separate IMO would make changing the look of the tab bar easier to find. Also, once we start to introduce more DHTML CSS styles, not all pages will require these. I would expect new css files for these as well. I'm just afraid that combining all styles into one file will make it more complicated to find and customize. Then again, David's comment on keeping them separated nicely with comments may accomplish the same thing as having properly named separated css files.

I'd like to help with that effort. From my perspective, I see it happening kinda like this:

1. Combine maincss.css and tabstyles.css files into one file.






Tim Ruppert wrote:

2. Test css classes on a single component (what Jacopo is doing now), tweak css class settings. 3. Once css class settings are finalized, go through all widgets and ftl files to eliminate embedded styles. I'm not a css wizard, so I can't be of much help with #1 and #2. I can help with #3 though.

I have a good start on cleaning up the backend to look just like the existing site as an intermediate solution. I'll do my best to clean it up a bit and get that out, but I'm swamped at the moment. I had also identified a LARGE number of places where styles were embedded in the code. This is definitely something I'd love to help out with.

Cheers,
Tim
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com
o:801.649.6594
f:801.649.6595
On Jan 3, 2007, at 4:49 PM, David E Jones wrote:

-David


On Jan 3, 2007, at 1:05 PM, Adrian Crum wrote:

Yeah, ecommerce has always been the highest priority in my mind but improving styling and L&F in general on the back-end would also be great.

Thanks David.




David E Jones wrote:

I remember you mentioning some time ago your desire for the UI to be "more Zen Garden-esque." More than likely you were referring to the eCommerce component, but I don't see why the same can't be true for the rest of OFBiz. At the time you suggested it, I pictured these two files being combined and - as Chris has suggested - clear comments inserted to assist developers with modifying OFBiz's appearance.

On Jan 3, 2007, at 12:36 PM, Chris Howe wrote:

Having them separated allows the flexibility to use a
different style sheet if desired without needing to
assign properties for everything that the stylesheet
being replaced has declared for a particular class or
id.

All back end components utilize both because most were
developed by copying another component, not because of
a decision that they _should look the same. I think
Open Source Strategies CRM component testifies to that
(although they may be simply using the cascading
effect of css as opposed to a stylesheet replacement).

Actually no, the back-end applications use the same styles because they ARE meant to look the same. The OpenSourceStrategies stuff is not part of OFBiz and they certainly can (and obviously have) introduced their own patterns.

 Personally, I would prefer additional separation of
maincss.css into the groups that are divided by
comments, but it's a rather trivial distinction.

-David

I agree, it is rather trivial. I don't see any problem with combining these files.

--- Adrian Crum <[EMAIL PROTECTED]> wrote:

Maintaining a single css file instead of two. All
components reference both
files, so there's no sense to keep them separate.


Chris Howe wrote:

What benefit do you see in doing this?


--- Adrian Crum <[EMAIL PROTECTED]> wrote:

Jacopo,

While we're on the subject, could we also discuss
the possibility of combining
the maincss.css and tabstyles.css files into one
file?


Jacopo Cappellato wrote:

Following the great advices in
https://issues.apache.org/jira/browse/OFBIZ-241

I've started to play

with the styles in maincss.css file and apply the

mods to the

manufacturing application.

I've noticed some minor side effects (for example

the texts in the main

webtools page are smaller now) and I wanted to be

sure that the work I'm

doing is correct and, most of all, if it is a

good

moment to do this

work now (i.e. before a release).
So please, have a look at the revisions 492187,

492201, 492242

(especially at the changes I did to the

maincss.css file) and let me

know what you think.

Jacopo

smime.p7s
Description: S/MIME cryptographic signature