Hi Ryan,
> The modem.conf options for the driver portion of the patch.
Patch has been applied with some refactoring afterward. I know you ran
checkpatch.pl, but please make sure you follow the coding standard even for
parts which checkpatch.pl does not catch. In particular:
> +static const char *tty_opts[] =
> + {
> + "Baud",
> + "Read",
> + "Local",
> + "StopBits",
> + "DataBits",
> + "Parity",
> + "XonXoff",
> + "Rtscts",
> + NULL,
> + };
- There are spaces for indentation, ONLY tabs should be used.
- The opening brace should be on the tty_opts line.
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
