Hi Andrew,

> Now with the attachment..
> 

Some comments:

 struct ofono_sim {
        char *imsi;
+       int phase;
        unsigned char mnc_length;
        GSList *own_numbers;
        GSList *new_numbers;

Enum or an unsigned char for phase please.

+       sim->phase = (ok && length == 1) ? data[0] == 0x00 ? 1 : 2 : 3;
+

This seriously makes my brain hurt.  Don't do this.

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to