Hi Sjur, > Added STE as vendor and quirks needed in "atmodem" for ST-Ericsson modem. > Added at_util_call_compare_by_id
please put the addition of at_util_call_compare_by_id in a separate patch. It doesn't really belong here. The rest looks fine to me. Except that you are using hardcoded CIND indexes. That is acceptable for the first inclusion, but we expect you to fix that in an update. So if you split this into two patches re-submit then, then I see no problem in applying them. Regards Marcel _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono