On Thu, Jan 21, 2010 at 7:20 PM, Vinicius Gomes
<[email protected]> wrote:
> Hi Gustavo,
>
> On Thu, Jan 21, 2010 at 5:31 PM, Gustavo F. Padovan
> <[email protected]> wrote:
>> + gw->sco = chan;
>> + g_io_channel_ref(chan);
>> +
>
> You must have forgotten to change this.
>
>> @@ -307,17 +565,15 @@ struct gateway *gateway_init(struct audio_device *dev)
>> {
>> struct gateway *gw;
>>
>> + gw = g_new0(struct gateway, 1);
>> +
>> if (!g_dbus_register_interface(dev->conn, dev->path,
>> AUDIO_GATEWAY_INTERFACE,
>> gateway_methods, gateway_signals,
>> NULL, dev, NULL))
>> return NULL;
>>
>
> Seems like gw is leaking if registration fails. Move it down a little,
> perhaps?
Sounds good. Thanks. :)
>
>> - debug("in gateway_init, dev is %p", dev);
>> - gw = g_new0(struct gateway, 1);
>> - gw->state = GATEWAY_STATE_DISCONNECTED;
>> return gw;
>> -
>> }
>>
>
>
> Cheers,
> --
> Vinicius Gomes
> INdT - Instituto Nokia de Tecnologia
>
--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
