Hi Marcel,

> > > And we might wanna check if MBM cards behave similar and ensure that
> > > STE and MBM cards use a similar code flow.
> >
> > When testing this EIAAUW fails if there are no prior PDP context on the
> > modem. Most likely this is the case with the MBM module as well, but I
> > have not tested this.
> 
> Then we have to do that in the callback in an extra step. I don't really
> like it, but seems the way to go. Please send a patch that also changes
> this for MBM devices. We really wanna keep these in sync.

Actually the easiest way to do this is simply queue the EIAAUW after the 
CGDCONT in activate_context.  If CGDCONT fails then EIAAUW won't have any 
effect anyway (but will get executed nevertheless).  This is better than 
worrying about strduping username/password and freeing it in all possible code 
paths.

Regards,
-Denis

> 
> Regards
> 
> Marcel
> 
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Reply via email to