Hi Kristen,
> static GAtChat *control;
> static GAtChat *modem;
> static GMainLoop *event_loop;
> +static GAtPPP *ppp;
I hate myself for this nitpick, but please group GAtPPP *ppp with the
others before the mainloop variable.
> +static void print_ip_address(guint32 ip_addr)
> +{
> + struct in_addr addr;
> + addr.s_addr = ip_addr;
> + g_print("%s\n", inet_ntoa(addr));
> +}
Please use print_ip_address(const char *label, guint32 ip_addr) as
mentioned in the previous review.
> + /* open ppp */
> + ppp = g_at_ppp_new(channel);
> + if (!ppp) {
> + g_print("Unable to obtain PPP object\n");
> + return;
> + }
I would call it "Unable to create PPP object", because you are creating.
My understanding is the obtaining means that it would be there in the
first place. It is a nitpick.
Regards
Marcel
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
