2010/3/23 Denis Kenzior <denk...@gmail.com>: >> Add support for lock codes AG and AC (MMI codes 333 and 353. respectively). > > First of all, please keep your commit messages less than 72 characters long > and headings less than 50 characters long.
Is there any git setting or nice filter which could complain automatically if the limits are reached? >> + SS_GSM_ALL_FORWARDINGS = 002, >> + SS_GSM_ALL_COND_FORWARDINGS = 004, > > Are you sure this isn't octal syntax? It still works, but you might simply > use 2 and 4 here. Those values equal to MMI codes (002 and 004); I just think it is a good idea to show it. > From now on we'll require all enum values to be tab aligned so they're a bit > easier to read. See src/stkutil.h for reference. I've reformatted <ss.h>. -- Pekka.Pessi mail at nokia.com _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono