Hi Kristen, > --- > gatchat/gathdlc.c | 75 ++++++++++++++++++++++++++++------------------------ > 1 files changed, 40 insertions(+), 35 deletions(-) > > diff --git a/gatchat/gathdlc.c b/gatchat/gathdlc.c > index c5c02cf..13e15a1 100644 > --- a/gatchat/gathdlc.c > +++ b/gatchat/gathdlc.c > @@ -59,11 +59,12 @@ static void new_bytes(GAtHDLC *hdlc) > { > unsigned int len = ring_buffer_len(hdlc->read_buffer); > unsigned char *buf = ring_buffer_read_ptr(hdlc->read_buffer, 0); > + unsigned int wrap = ring_buffer_len_no_wrap(hdlc->read_buffer); > unsigned char val; > unsigned int pos = 0; > > while (pos < len) { > - if (buf[pos] == 0x7e) { > + if (*buf == 0x7e) { > if (hdlc->receive_func && hdlc->decode_offset > 2 && > hdlc->decode_fcs == 0xf0b8) { > hdlc->receive_func(hdlc->decode_buffer,
please do this patch fist and send it separately. Intermixing it with the ACCM support makes it hard to review. So I like to see the patch series this way: 1) Handle ringbuffer wrapping in HDLC 2) Add recording support for HDLC 3) Add ACCM support to HDLC 4) Port PPP to use HDLC Regards Marcel _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono