"Zhang, Zhenhua" <zhenhua.zh...@intel.com> writes:

> Hi Valo,

Hi Zhenhua,

> Kalle Valo wrote:
>> -    channel = g_at_chat_get_channel(gcd->chat);
>> -    g_at_chat_unref(gcd->chat);
>> +    g_at_chat_suspend(gcd->chat);
>> 
>>      /* open ppp */
>> -    gcd->ppp = g_at_ppp_new(channel);
>> +    gcd->ppp = g_at_ppp_new_from_io(io);
>> 
>>      if (gcd->ppp == NULL)
>>              return FALSE;
>
> You should use g_at_chat_resume(gcd->chat) to resume the chat before
> you returns FALSE here.

Good point. I just sent v3, but I'll send v4 immeadiately.

-- 
Kalle Valo
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Reply via email to