Hi Niko, On 07/14/2010 09:03 PM, Nicola Mfb wrote: > Hi! > I tried SendTones with calypso during an active call but it failed (v0.22): > > ofonod[259]: DLC0: > AT\r > ofonod[259]: DLC0: < \r\nOK\r\n > ofonod[259]: DLC0: Finally woke up the modem > ofonod[259]: DLC0: > AT+VTS="1"\r > ofonod[259]: DLC0: < \r\nERROR\r\n > ofonod[259]: src/voicecall.c:generic_callback() command failed with > error: Unknown error type > > Am I missing somethings? >
I admit I never tested it on the calypso. I have a hunch that the quotes are not needed for the DTMF character. E.g. AT+VTS=1. Can you try the attached patch and report back? Thanks, -Denis
diff --git a/drivers/calypsomodem/voicecall.c b/drivers/calypsomodem/voicecall.c index ae49eb0..511d533 100644 --- a/drivers/calypsomodem/voicecall.c +++ b/drivers/calypsomodem/voicecall.c @@ -209,10 +209,10 @@ static void calypso_send_dtmf(struct ofono_voicecall *vc, const char *dtmf, return; } - s = sprintf(buf, "AT+VTS=\"%c\"", dtmf[0]); + s = sprintf(buf, "AT+VTS=%c", dtmf[0]); for (i = 1; i < len; i++) - s += sprintf(buf + s, ";+VTS=\"%c\"", dtmf[i]); + s += sprintf(buf + s, ";+VTS=%c", dtmf[i]); calypso_template(vc, buf, cb, data); g_free(buf);
_______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
