Hi Andrew,
> +static struct stk_menu *stk_menu_create(const char *title,
> + const struct stk_text_attribute *title_attr, GSList *items,
> + const struct stk_item_text_attribute_list *item_attrs,
> + const struct stk_items_next_action_indicator *next_action,
> + int default_id, gboolean soft_key, gboolean has_help)
> +{
I suggest breaking up this giant constructor with many arguments into
two functions. One that takes a setup_menu object and one that takes a
select_item object. Then fills in the items appropriately.
Regards,
-Denis
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
