Hi Sjur, > >do we really wanna create another vendor quirk here. If both modems > >behave identical then just pass OFONO_VENDOR_MBM in the SIM atom > >registration and be done with it. > > Re-use the MBM quirk rather than adding STE quirks in atmodem/sim.c > > --- > plugins/ste.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/plugins/ste.c b/plugins/ste.c > index 9cb49d3..9d9afd6 100644 > --- a/plugins/ste.c > +++ b/plugins/ste.c > @@ -214,7 +214,7 @@ static void ste_pre_sim(struct ofono_modem *modem) > > ofono_devinfo_create(modem, 0, "atmodem", data->chat); > sim = ofono_sim_create(modem, 0, "atmodem", data->chat); > - ofono_voicecall_create(modem, 0, "stemodem", data->chat); > + ofono_voicecall_create(modem, OFONO_VENDOR_MBM, "stemodem", data->chat);
this looks wrong. You are using a STE specific modem driver already. Why do you need to pass a quirk here as well. Did I confuse you with one of my other replies or did I confuse myself here in the review? Regards Marcel _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
