Hi Pekka,

> No AT+CGEREP=2,1 on mbm either.
> ---
>  plugins/mbm.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/plugins/mbm.c b/plugins/mbm.c
> index a06c444..e77e61c 100644
> --- a/plugins/mbm.c
> +++ b/plugins/mbm.c
> @@ -395,7 +395,8 @@ static void mbm_post_sim(struct ofono_modem *modem)
>       ofono_cbs_create(modem, 0, "atmodem", data->modem_port);
>       ofono_ussd_create(modem, 0, "atmodem", data->modem_port);
>  
> -     gprs = ofono_gprs_create(modem, 0, "atmodem", data->modem_port);
> +     gprs = ofono_gprs_create(modem, OFONO_VENDOR_STE, "atmodem",
> +                                     data->modem_port);
>       gc = ofono_gprs_context_create(modem, 0, "mbm", data->modem_port);

looks good, but I actually prefer if we turn this around. Make the quirk
in drivers/atmodem/gprs.c an OFONO_VENDOR_MBM quirk with a proper
comment that this applies to STE and MBM modems. And then have the MBM
and STE plugin use that quirk.

Regards

Marcel


_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Reply via email to