Hi Kristen,

> +static void sim_efimg_read_cb(int ok, int length, int record,
> +                             const unsigned char *data,
> +                             int record_length, void *userdata)
> +{
> +     struct ofono_sim *sim = userdata;
> +     unsigned char *efimg;
> +     int num_records;
> +
> +     if (!ok)
> +             return;
> +
> +     num_records = length / record_length;
> +
> +     /*
> +      * EFimg descriptors are 9 bytes long.
> +      * Byte 1 of the record is the number of descriptors per record.
> +      */
> +     if (record_length < 10)
> +             return;
> +

See my reply to the previous version regarding being more pedantic.  Fix
that and lets get this one upstream.

Regards,
-Denis
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Reply via email to