Hi,
2010/8/17 Denis Kenzior <denk...@gmail.com>:
> Why are we doing this inside n900modem? Can't we simply:
>
> 1. Make isimodem/isimodem.c register these (just like atmodem, stemodem,
> mbmmodem, etc does)
> 2. Rip out the actual modem driver out of isimodem/isimodem.c
> 3. Have plugins/n900.c contain the modem driver?
I think you mean rip out the modem driver in isimodem/isimodem.c, and
put it in usbpnmodem.c? I think that makes sense.
>> - /* Expect phonet interface name usbpn<idx> */
>> - if (strncmp(ifname, "usbpn", 5) ||
>> - ifname[5 + strspn(ifname + 5, "0123456789")])
>> + if (match_ifname("usbpn", ifname)) {
>> + driver = "isimodem";
>> + address = PN_DEV_PC;
>> + } else if (strcmp("phonet0", ifname) == 0) {
>> +#if HAVE_N900MODEM
>> + driver = "n900modem";
>> +#else
>> + driver = "isimodem";
>> +#endif
>
> And this really needs to go...
Couldn't we rather either build support for native modem or USB
modems, but not both at the same time? In other words, build only one
or the other of these two plugins.
Cheers,
Aki
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
