Hi Jeevaka,

On 09/01/2010 06:00 AM, Jeevaka Badrappan wrote:
> ---
>  src/call-barring.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/src/call-barring.c b/src/call-barring.c
> index 7607f3f..b58499a 100644
> --- a/src/call-barring.c
> +++ b/src/call-barring.c
> @@ -580,6 +580,11 @@ static void cb_unregister_ss_controls(struct 
> ofono_call_barring *cb)
>       __ofono_ussd_passwd_unregister(cb->ussd, "353");
>  }
>  
> +gboolean __ofono_call_barring_is_busy( struct ofono_call_barring *cb)
> +{
> +     return cb->pending ? TRUE: FALSE;
> +}
> +
>  static inline void cb_append_property(struct ofono_call_barring *cb,
>                                       DBusMessageIter *dict, int start,
>                                       int end, int cls, const char *property)

The rule of thumb for patch submissions is to:
- Make sure all related chunks are together in one patch
- Chunks are only related to the particular change being described
- Unless impossible / extremely hard, the code should compile after each
individual patch.

In this case, please merge the chunks from patch #8 related to call
barring into this patch.

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to