Hi Aki,

On 09/03/2010 07:15 AM, Aki Niemi wrote:
> On Thu, 2010-09-02 at 18:55 +0200, ext Denis Kenzior wrote:
>>> -   if (offset != 0)
>>> -           template.submit.udhi = FALSE;
>>> -
>>
>> This part doesn't look right.  The check should actually set udhi to
>> TRUE, since we can be issuing a return in the next if statement...
> 
> That's why it's removed. This was doing nothing before, as offset at
> this point was always zero, and the template had anyway been memset to
> zero.
> 

I see what you're doing now.  I'd rather you left out setting udhi in
the dialect switch/case labels and changed this line to set UDHI to TRUE.

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to