Hi John, On 11/10/2010 06:25 AM, John Mathew wrote: > --- > TODO | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/TODO b/TODO > index 84d5aa7..ed37c58 100644 > --- a/TODO > +++ b/TODO > @@ -416,7 +416,7 @@ Emergency Calls > > Priority: High > Complexity: C1 > - > + Owner: John Mathew <john.mat...@elektrobit.com> > > Miscellaneous > =============
We have pretty strict git apply settings in effect, so your patch does not apply: Applying: TODO: Add owner to extend the voicecall interface with a property indicating emergency call /home/denkenz/ofono-master/.git/rebase-apply/patch:14: trailing whitespace. Owner: John Mathew <john.mat...@elektrobit.com> fatal: 1 line adds whitespace errors. Patch failed at 0001 TODO: Add owner to extend the voicecall interface with a property indicating emergency call Also, please keep your commit header under 50 characters. And yes, I know the task description is rather 'long' in this case ;) So sometimes we have to be a bit 'creative'. Something like: "TODO: Assign Voicecall emergency property task" would work in this case. Regards, -Denis _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
