Hi George. > it looks as if two functions: > > caif_if_create/remove (struct conn_info *conn) > > do nothing but verify the return results of functions: > > caif_rtnl_create_interface/caif_rtnl_delete_interface > > declared in in caif_rtnl.h > > Which means if you #include caif_rtnl.h in gprs-context.c > create/delete_interface will be available directly without any wrappers > and could make your code run a bit faster and easier to understand? > Unless I missed something.
Thank you for reviewing this patch :-) Yes, you are right concerning caif_if_create, I'll change this. But caif_if_remove needs to stay as is, it is called from g_slist_foreach and must have the list node as argument. BTW you should take a look at http://ofono.org/wiki/ofono-etiquette. Top-posting is not exactly popular on this list ;-) Regards, Sjur _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono