On Friday 26 November 2010 23:12:09 ext Denis Kenzior, you wrote:
> On 11/25/2010 04:51 AM, Rémi Denis-Courmont wrote:
> > strerror() is not thread-safe, nor in the glibc implementation,
> > nor in the POSIX specification. In my experience, it will infrequently
> > crash when another thread uses locale data in any way, including
> > string formatting and such...
> > 
> > Since the Huawei driver uses thread, we might as well avoid strerror().
> > ---
> > 
> >  drivers/isimodem/sim.c |    3 ++-
> >  plugins/hfp.c          |    4 ++--
> >  plugins/isigen.c       |   13 ++++++++-----
> >  plugins/n900.c         |   14 +++++++-------
> >  plugins/nokia-gpio.c   |   29 +++++++++++++++++------------
> >  5 files changed, 36 insertions(+), 27 deletions(-)
> 
> Since we do not use threads, do you still want this patch?  If you do,
> can you please break this up into two patches, one for drivers/isimodem
> and one for plugins?  We prefer patches to be split by directory.

Why do we initialize glib and dbus with thread support? If the plan is to 
smoothen the hypothetical use of threads in the future, then this patch should 
probably go in as well?

-- 
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to