Hi Rajesh,
On Thu, Dec 2, 2010 at 7:33 AM, <rajesh.naga...@elektrobit.com> wrote: > Hi Sankar, > > > In the decode SMS function, there is a check to find out if > > there is a PI (parameter identifier). If there is a PI and no > > DCS flag set, then the ofono core sets the dcs to default. If > > the PI itself is missing in the PDU received from the > > network, then the dcs values are not set to default. > > > > This seems to cause a problem, where, the decoding of dcs > > fails, and results in not sending the delivery notification > > to clients. > > Yes, this is a bug. But rather than setting the DCS to default in > this case, we should rather not call that sms_dcs_decode() function > from ofono_sms_status_notify(), as the class information derived from > the DCS decoding is not used there and also we are not handling the > optional text information in the status report handling currently. > > If we decide to handle this optional text information (most likely not > going to happen), then some modifications are required. > > Also there is another bug in the current code which might not be > relevant > if we decide to remove the sms_dcs_decode() function call from > ofono_sms_status_notify(). In that function call instead of passing > s.status_report.dcs, we are currently passing s.deliver.dcs. > Thanks for your inputs. Can you please let me know when this will be addressed in the ofono. > > BR, > Rajesh > _______________________________________________ > ofono mailing list > ofono@ofono.org > http://lists.ofono.org/listinfo/ofono >
_______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
