On Saturday 04 December 2010 02:02:56 ext Marcel Holtmann, you wrote: > Hi Aki, > > > The only thing I would change here are the names. It's customary to > > avoid repeating the interface name in the signal or method, but of > > course the problem here is then what to call these. Maybe just Get() > > and Changed()? ;-) > > > > Oh, and you probably should have included a short description of what > > this plugin is for (I forgot to mention this before). > > > > The thinking behind this plugin is that timed in MeeGo wants to get > > the information, and a D-Bus API is a fine way to accomplish this. > > where is this timed running? I prefer the plugin just send a D-Bus > message to the timed directly instead of a Get/Changed API kind of > thing.
AFAIK, Get/Changed is the simplest functional way to avoid races, where say oFono would receive the time before timed can process it. The getter also enables implementing trivial a tool à la ntpdate. -- Rémi Denis-Courmont Nokia Devices R&D, Maemo Software, Helsinki _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
