Hi Guillaume,
>
> According to 3GPP TS 31.124 a null length for the text string
> should be allowed. An empty string must be returned to the
> user in this case.
> ---
> src/stkutil.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
Agree. As per the 3GPP TS 31.124 null text string will be indicated with
length 0.
So, in first place if (text == NULL) check in handle_command_get_input,
handle_command_get_inkey has to be removed. Removing this check will
result
in crash due to the fact that we are not handling this case properly
neither
in parse_dataobj_text nor in corresponding stkagent functions.
There are 2ways to solve this issue:
First option - Fix provided in the function parse_dataobj_text( e.g.
*text = "")
Second option - In all the stk_agent_ function which has this text
string we
need to check for NULL and assign it to empty string if
it is NULL.
First option seems to be right and also better one.
In both the cases, if (text == NULL) check in handle_command_get_inkey,
handle_command_get_input etc needs to be removed.
Regards,
Jeevaka
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
