Hi Jeevaka, On 12/17/2010 01:04 AM, Jeevaka Badrappan wrote: > --- > src/call-forwarding.c | 243 > ++++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 241 insertions(+), 2 deletions(-) >
So I applied this patch but refactored it very heavily afterward. Can you do review the changes and make sure you're OK with them? Can you also submit the needed records for phonesim, so we can get those tested as well? I still have one concern with cfis_record_id selection logic. There are a couple of possibilities we might not be handling correctly: - if no EFcfis records contain proper MSP ids - if EFcfis record has a valid MSP id, but is relevant to teleservices besides voice. We still potentially select this record, even though a voice specific record might or might not exist. Overall I think we need to test this feature quite a bit more... Regards, -Denis _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
