Hi Marcel

Thank you for reviewing these patches

On 12/18/2010 10:29 AM, ext Marcel Holtmann wrote:
Hi Dara,

        struct ofono_modem *modem;
@@ -533,6 +552,8 @@ done:
                add_isi(modem, udev_device);
        else if (g_strcmp0(driver, "n900") == 0)
                add_isi(modem, udev_device);
+       else if (g_strcmp0(driver, "cdmagen") == 0)
+               add_cdmagen(modem, udev_device);
  }

this is actually wrong. The generic drivers running against phonesim
should not be done via udev. We did remove atgen for a reason actually
since it was not really useful.

Actually, this driver is not for running against phonesim at all. This plugin is intended for use against the majority of CDMA AT Modem devices (phones and usb sticks) connected in a tethered mode. Please see the other email thread in this series ([Patch v2 7/9]) for alternative name suggestion to clarify this.

Thanks
Dara
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Reply via email to