Hi Antti,
> > > ---
> > > include/cell-info.h | 133
> > > +++++++++++++++++++++++++++++++++++++++++++++++++++
> > > 1 files changed, 133 insertions(+), 0 deletions(-) create mode
> > > 100644 include/cell-info.h
> > >
> > > diff --git a/include/cell-info.h b/include/cell-info.h new file mode
> > > 100644 index 0000000..3941e69
> > > --- /dev/null
> > > +++ b/include/cell-info.h
> > > @@ -0,0 +1,133 @@
> > > +/*
> > > ...
> > > ...
> > > ...
> > > +struct ofono_cell_info_driver {
> > > + const char *name;
> > > + int (*probe)(struct ofono_cell_info *ci,
> > > + unsigned int vendor,
> > > + void *data);
> > > + void (*remove)(struct ofono_cell_info *ci);
> > > + void (*query)(struct ofono_cell_info *ci,
> > > + ofono_cell_info_query_cb_t,
> > > + void *data);
> > > +};
> > > +
> >
> > To be aligning with the other header files, do we need to add one 'cb'
> > after 'ofono_cell_info_query_cb_t' here?
>
> This seems to be a matter with no clear convention. In "sms.h" and
> "netreg.h" some callbacks have 'cb' and some not. I agree that if within
> a function's parameter list some parameters have name declared, so
> should all have.
we are trying to be consistent, but some of these slipped through in the
initial development phase of oFono.
Once we find them, we document them in doc/coding-style.txt and then
slowly start fixing these up. This is an ongoing process and pretty hard
if your codebase reaches over 100k lines of code.
Regards
Marcel
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
