Hi Rémi, On 01/10/2011 05:33 AM, Rémi Denis-Courmont wrote: > On Friday 07 January 2011 18:25:32 ext Denis Kenzior, you wrote: >> Hi Rémi, >> >> On 01/07/2011 10:02 AM, Rémi Denis-Courmont wrote: >>> --- >>> >>> include/gprs.h | 2 ++ >>> src/gprs.c | 32 ++++++++++++++++++++++++++++++++ >>> 2 files changed, 34 insertions(+), 0 deletions(-) >> >> please see the 'Submitting patches' section in HACKING > > The rules are self-contradictory. Either the patch spreads multiple > directories, or it breaks compilation. >
They are really not. For 99% of the time you need to break up your patches like this and it works out nicely. > For the sake of git-bisect'ing, I'd rather not break compilation. > What are you talking about? Adding a function declaration that nobody yet calls is not going to break compilation or git bisect. Regards, -Denis _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono