Hi Jeevaka,

>> +    buffer = g_malloc(len);
> 
> missing check for buffer memory allocation failure 
> 

Actually he's using g_malloc, so the application will simply abort.

>> +    sad = g_new0(struct sim_auth_data, 1);
> 
> missing check for "sad" memory allocation failure 

Same here.

My view is that checking mallocs of small structures is pretty much
pointless on Linux.

Regards,
-Denis
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Reply via email to