Hi Martin, >> You still forgot to apply my earlier comment. The recv ACCM should be >> set to what is acked by the peer. e.g.: > That is not this patch want to resolve. This patch is just used to fix the > mixing up of setting recv ACCM and transit ACCM, And fix Huawei modem issue. > > 1. Currently, it is just ACKed by peer. You know It is called at lcp_rca, and > here the code always use ACCM as 0x0. So that is just the acked ACCM.
Then please send a 2nd patch that just sets the recv ACCM to the one acked by the peer if you want to be pedantic. But changing the chunk once, then changing it in the second chunk to some other value will only serve to confuse me or anyone who reviews your patch submissions. Regards, -Denis _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
