Hi Denis, 2011/2/2 Denis Kenzior <denk...@gmail.com>: > On 02/01/2011 04:22 PM, pekka.pe...@nokia.com wrote: >> From: Pekka Pessi <pekka.pe...@nokia.com> >> >> There were some cases where Dial returned an incorrect call object, >> e.g., after oFono crash and recover. >> --- >> src/voicecall.c | 15 +++++++++++++++ >> 1 files changed, 15 insertions(+), 0 deletions(-) > > So I'm guessing that you're restarting oFono and get > ofono_voicecall_notify events without setting dial_result_handled properly. > > Do you think it is a better idea to resurrect the old list_calls driver > method and fire this off explicitly when the atom is registered? The > callback can then take care of setting dial_result_handled appropriately.
That is one possibility.The belt-and-suspenders approach of prepare_to_dial() makes oFono more robust in case there is someone talking directly to modem behind oFono's back, however. -- Pekka.Pessi mail at nokia.com _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
