Hi Amit,
On 02/09/2011 11:15 PM, Amit Mendapara wrote:
> Signed-off-by: Amit Mendapara <mendapara.a...@gmail.com>
Please note that we do not use the Signed-off-by. Configure your git
settings not to send this.
> ---
> Makefile.am | 3 +
> plugins/linktop.c | 357
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 360 insertions(+), 0 deletions(-)
> create mode 100644 plugins/linktop.c
So I applied this patch, however there's one thing I'd like you to fix:
> +static int linktop_enable(struct ofono_modem *modem)
> +{
> + struct linktop_data *data = ofono_modem_get_data(modem);
> +
> + DBG("%p", modem);
> +
> + data->modem = open_device(modem, "Modem", "Modem: ");
> + if (data->modem == NULL)
> + return -EINVAL;
> +
> + g_at_chat_set_disconnect_function(data->modem,
> + linktop_disconnect, modem);
> +
> + data->control = open_device(modem, "Control", "Control: ");
> + if (data->control == NULL) {
> + g_at_chat_unref(data->modem);
> + data->modem = NULL;
> + return -EIO;
> + }
> +
> + g_at_chat_send(data->control, "ATE0 +CMEE=1", none_prefix,
> + NULL, NULL, NULL);
> +
> + g_at_chat_send(data->modem, "AT", none_prefix,
> + NULL, NULL, NULL);
> +
> + g_at_chat_send(data->modem, "AT &F", none_prefix,
> + NULL, NULL, NULL);
> +
> + g_at_chat_send(data->control, "AT+CFUN=1", none_prefix,
> + cfun_enable, modem, NULL);
> +
oFono expects the modem driver to power up the modem in an 'offline'
state. So using CFUN=1 is fine, but it might need to be followed by a
CFUN=4 afterward. Look at a few other drivers to see the creative ways
we have tried to address this.
> + return -EINPROGRESS;
> +}
Regards,
-Denis
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
