On Tue, Feb 22, 2011 at 4:22 PM, Gustavo F. Padovan <pado...@profusion.mobi> wrote: > Hi Antoine,
Hi >> + if (!g_isi_sb_iter_get_byte(sb, &pres, 2) || >> + !g_isi_sb_iter_get_byte(sb, &id, 6) || >> + !g_isi_sb_iter_get_byte(sb, &len, 7) || >> + !g_isi_sb_iter_get_alpha_tag(sb, &name, 2 * len, 8)) >> + return; > > > Isn't this better: > > if (!g_isi_sb_iter_get_byte()) > return; > if (!g_isi_sb_iter_get_byte()) > return; > if (!g_isi_sb_iter_get_byte()) > return; > if (!g_isi_sb_iter_get_alpha_tag()) > return; It is better, my code is based on isi_call_any_address_sb_proc which has the same construct. I guess I'll fix both then. > I'll fix the rest and resend the patch, thanks. _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
