Hi Andrew,
Andrzej Zaborowski wrote:
> Hi Jeevaka
>
> On 7 March 2011 16:35, Jeevaka Badrappan
> <jeevaka.badrap...@elektrobit.com> wrote:
>> As per the specification, if alphad identifier is provided and is a
>> null data object, no information should be given to the user.
>
> What do do you think of the following change?
>
> diff --git a/src/stkutil.c b/src/stkutil.c index
> abd1c99..c64cb7a 100644
> --- a/src/stkutil.c
> +++ b/src/stkutil.c
> @@ -309,7 +309,7 @@ static gboolean
> parse_dataobj_alpha_id(struct comprehension_tlv_iter *iter,
>
> len = comprehension_tlv_iter_get_length(iter); if
> (len == 0) { - *alpha_id = g_try_malloc0(1);
> + *alpha_id = NULL;
> return TRUE;
> }
>
>
> This actually lets the caller detect a NULL alpha identifier
> and then, as far as I can see, the stk.c code will not give
> any information to the user if either the alpha_id is NULL or not
> provided.
Change is fine with me.
Regards,
Jeevaka
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
