Hi Frédéric,
On 04/13/2011 11:05 AM, Frédéric Danis wrote:
> ---
> src/emulator.c | 82
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 81 insertions(+), 1 deletions(-)
>
Patch has been applied, thanks. One more comment:
> +static void notify_ring(struct ofono_emulator *em)
> +{
> + struct ofono_call *c;
> + const char *phone;
> + /*
> + * '+CLIP: "+",' + phone number + phone type on 3 digits max
> + * + terminating null
> + */
> + char str[OFONO_MAX_PHONE_NUMBER_LENGTH + 14 + 1];
> +
> + g_at_server_send_unsolicited(em->server, "RING");
> +
> + if (!em->clip)
> + return;
> +
> + c = find_call_with_status(em, CALL_STATUS_INCOMING);
> +
> + if (c && c->clip_validity == CLIP_VALIDITY_VALID) {
The spec really doesn't cover this, but you might want to send the CLIP
even in withheld cases. Or is there a reason why you did it this way?
> + phone = phone_number_to_string(&c->phone_number);
> + sprintf(str, "+CLIP: \"%s\",%d", phone, c->phone_number.type);
> +
> + g_at_server_send_unsolicited(em->server, str);
> + }
> +}
> +
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
