Hi Arun,
2011/5/18 Arun Ravindran <arun...@gmail.com>:
> + case CALL_STATUS_MT_RELEASE:
> + if ((call->prev_status == CALL_STATUS_MT_ALERTING) ||
> + (call->prev_status == CALL_STATUS_COMING) ||
> + (call->prev_status == CALL_STATUS_WAITING))
> + return 4;
> + else
> + return 6;
> +
Extra whitespace here.
> case CALL_STATUS_ACTIVE:
> case CALL_STATUS_HOLD_INITIATED:
> return 0;
> @@ -548,9 +555,14 @@ static void isi_call_notify(struct ofono_voicecall *ovc,
> struct isi_call *call)
>
> case CALL_STATUS_MO_RELEASE:
> case CALL_STATUS_MT_RELEASE:
> + isi_call_set_disconect_reason(call):
> + break;
> +
> case CALL_STATUS_TERMINATED:
> isi_call_set_disconnect_reason(call);
> - break;
> + DBG("State( CALL_STATUS_TERMINATED ) need not be reported to
> Core");
> + return;
> +
> case CALL_STATUS_ANSWERED:
> DBG("State need not be reported to Core");
> return;
If the intention is not to report this up, then why set the disconnect
reason with isi_call_set_disconnect_reason()? Why not just fold these
two case statements together?
Cheers,
Aki
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
