Hi Guillaume,

On 05/19/2011 04:58 AM, Guillaume Zajac wrote:
> ---
>  Makefile.am               |    4 +-
>  include/private-network.h |   56 
> +++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 58 insertions(+), 2 deletions(-)
>  create mode 100644 include/private-network.h

I applied this patch, however I did fix up a few things afterwards:

> +typedef void (ofono_private_network_cb_t)(

Please make sure that this is a pointer, e.g. typedef void (*foo)(...);

> +             void *data,
> +             const struct ofono_private_network_settings *settings);

It is customary to have the userdata pointer as the last argument

Regards,
-Denis
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Reply via email to