Hi Oleg,
On 11/08/2011 06:46 AM, Oleg Zhurakivskyy wrote:
> ---
> Makefile.am | 2 +-
> gatchat/ppp.h | 8 +
> gatchat/ppp_ipv6cp.c | 377
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 386 insertions(+), 1 deletions(-)
> create mode 100644 gatchat/ppp_ipv6cp.c
Patch has been applied, however you made one small error here:
<snip>
> + switch (type) {
> + case IPV6CP_INTERFACE_ID:
> + memcpy(&ipv6cp->peer_addr, data,
> + sizeof(ipv6cp->peer_addr));
> + if (ipv6cp->peer_addr != 0)
> + break;
> + /*
> + * Fall through, reject zero Interface ID
> + */
> + break;
The break statement seems to be in error and I fixed it in a follow on
commit. Let me know if I was wrong.
> + default:
> + if (options == NULL) {
> + guint16 max_len = ntohs(packet->length) - 4;
> + options = g_new0(guint8, max_len);
> + }
> +
> + OPTION_COPY(options, len, options != NULL,
> + type, data,
> + ppp_option_iter_get_length(&iter));
> + break;
> + }
> + }
> +
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
