Hi Nicolas, On 03/22/2012 12:28 PM, Nicolas Bertrand wrote: > Fix issue with some modems preventing to update elementary files > (speedup, ZTE, huawei, MBM) > --- > drivers/atmodem/sim.c | 127 > ++++++++++++++++--------------------------------- > 1 files changed, 41 insertions(+), 86 deletions(-) >
Patch has been applied, but I had to fix up numerous coding style violations afterwards. Please re-read doc/coding-style.txt and pay extra attention next time. Just one more comment: > + sprintf(buf + len, "%s", quote); > Something like this is really wasteful, you're invoking sprintf (which is quite a heavy hammer) just to put in a quote character. Use buf[len] = '\"' next time. Regards, -Denis _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
