Hi Ronald,

>  src/service.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/src/service.c b/src/service.c
> index f148252..851db34 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -984,7 +984,12 @@ static gboolean load_message_from_store(const char 
> *service_id,
>       if (mms_message_decode(pdu, len, msg) == FALSE) {
>               mms_error("Failed to decode %s", data_path);
>               munmap(pdu, len);
> -             goto out;
> +             g_free(state);

are we not leaking data_path here?

> +
> +             mms_store_meta_close(service_id, uuid, meta, FALSE);
> +             mms_store_remove(service_id, uuid);
> +
> +             return FALSE;
>       }

And why are we turning a perfect good label into something were we have
the label and also duplicated code. This is not a good idea.

Regards

Marcel


_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Reply via email to